Modify test infrastructure and grunt tasks #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ |
rosen-vladimirov
force-pushed
the
vladimirov/unify-proton-and-master
branch
from
6fa0121 to
a8cd502
Compare
|
✅ |
rosen-vladimirov
force-pushed
the
vladimirov/unify-proton-and-master
branch
from
a8cd502 to
44349aa
Compare
|
❌ |
rosen-vladimirov
force-pushed
the
vladimirov/unify-proton-and-master
branch
from
44349aa to
797ac57
Compare
|
✅ |
As common lib is now a separate npm package, it has its own tests, that must be run when executing `grunt test` or `npm test` in nativescript-cli. Modify test command in package.json in order to run the tests. Change Gruntfile.js in order to ignore/build the correct typescript files in common lib. Add Bluebird as dependency as it is required for common lib. Update mocha version. Remove `chai` and `mocha` definitions as they are part of common lib now. Update some dev dependencies.
rosen-vladimirov
force-pushed
the
vladimirov/unify-proton-and-master
branch
from
797ac57 to
8ec9e09
Compare
|
✅ |
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Aug 5, 2015
…-master Modify test infrastructure and grunt tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As common lib is now a separate npm package, it has its own tests, that must be run when executing
grunt testornpm testin nativescript-cli. Modify test command in package.json in order to run the tests.Change Gruntfile.js in order to ignore/build the correct typescript files in common lib.
Add Bluebird as dependency as it is required for common lib.
Update mocha version.
Remove
chaiandmochadefinitions as they are part of common lib now.